Support multiple source jars #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongerrish
requested review from
cgruber,
djwhang,
jin,
restingbull and
timpeut
as code owners
|
Nice fix but wrong repo? though would be nice to upstream it while we're at it :) |
|
@nkoroste - why is this the wrong repo? |
cgruber
requested changes
Nov 4, 2020
cgruber
approved these changes
Nov 4, 2020
cgruber
reviewed
Nov 4, 2020
| @@ -30,7 +31,7 @@ class CoffeeApp { | |||
| companion object { | |||
| @JvmStatic | |||
| fun main(args: Array<String>) { | |||
| if (TeaPot.isEmpty()) { | |||
| if (TeaPot.isEmpty() && ChaiCup.isEmpty()) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including multiple source jars currently does not work as SourceJarExtractor fails to overwrite META-INF/MANIFEST.MF which is present in all jars.
Fix this by having SourceJarExtractor.preWrite() return true only for directories and files that match the extraction pattern.