Support -Xno-optimized-callable-references kotlinc flag #394
Conversation
Bencodes
requested review from
cgruber,
djwhang,
jin,
restingbull and
timpeut
as code owners
Bencodes
force-pushed
the
support-Xno-optimized-callable-references
branch
from
4d562a7 to
e9e321c
Compare
|
Rebased this one |
There was a problem hiding this comment.
Add a check in _kotlin_toolchain_impl on the version number is gte 1.4
kotlin/internal/opts.bzl
Outdated
| "x_no_optimized_callable_references": struct( | ||
| args = dict( | ||
| default = False, | ||
| doc = "Do not use optimized callable reference superclasses available from 1.4.", |
There was a problem hiding this comment.
nit: "Do not use optimized callable reference superclasses. Available from 1.4."
|
It would probably make more sense to do the validation in |
Reasonable, considering #418. |
Bencodes
force-pushed
the
support-Xno-optimized-callable-references
branch
from
5fb0f79 to
acc0b09
Compare
| @@ -162,7 +162,7 @@ def _adjust_resources_path(path, resource_strip_prefix): | |||
| return _adjust_resources_path_by_default_prefixes(path) | |||
|
|
|||
| def _merge_kt_jvm_info(module_name, providers): | |||
| language_versions = {p.language_version: True for p in providers if p.language_verison} | |||
| language_versions = {p.language_version: True for p in providers if p.language_version} | |||
There was a problem hiding this comment.
There seems to have been a typo here
|
Updated with some basic validation |
Bencodes
force-pushed
the
support-Xno-optimized-callable-references
branch
from
4ede8a5 to
4b050b8
Compare
|
Is it me, or the kotlinc flags getting longer? |
Bencodes
force-pushed
the
support-Xno-optimized-callable-references
branch
from
4b050b8 to
56b5c2f
Compare
|
Rebased this after all the kotlinc merges. |
|
Ah, thanks. Meant to rebase the pr and got distracted. |
https://github.com/JetBrains/kotlin/blob/68fdeaf865f279cb7a75eaec7e9f4e6cd0646707/compiler/testData/cli/jvm/extraHelp.out#L77-L78