-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version the kt_kotlinc_options and kt_javac_options. #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull
force-pushed
the
restingbull/versioned-options
branch
from
July 29, 2021 15:07
b01ac8f
to
aa9ddfe
Compare
restingbull
force-pushed
the
restingbull/versioned-options
branch
6 times, most recently
from
July 29, 2021 21:00
9326d32
to
53b5dce
Compare
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull
force-pushed
the
restingbull/versioned-options
branch
from
July 29, 2021 22:28
53b5dce
to
60c1e11
Compare
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
Remove Dagger tests, as examples handles them Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull
force-pushed
the
restingbull/versioned-options
branch
from
August 2, 2021 18:52
5e3eace
to
fb41786
Compare
cgruber
approved these changes
Aug 5, 2021
CONTRIBUTING.md
Outdated
|
||
### Multi-repo runtime | ||
|
||
The `rules_kotlin` runtime is comprised from multiple repositories. The end user will interact with a single repository, that repository delegates to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar nit: Either "is comprised of" or "comprises" (oddly).
examples/release_archive/README.md
Outdated
@@ -0,0 +1,3 @@ | |||
# archive workspace | |||
|
|||
archive pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
Fixing grammer.
add note.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass on repository-per-feature to support different rule apis per loaded versions.
This pr changes the loading of runtime option rules until the kotlin version is set.