Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version the kt_kotlinc_options and kt_javac_options. #564

Merged
merged 14 commits into from
Aug 6, 2021

Conversation

restingbull
Copy link
Collaborator

First pass on repository-per-feature to support different rule apis per loaded versions.

This pr changes the loading of runtime option rules until the kotlin version is set.

Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
@restingbull restingbull force-pushed the restingbull/versioned-options branch from b01ac8f to aa9ddfe Compare July 29, 2021 15:07
@restingbull restingbull force-pushed the restingbull/versioned-options branch 6 times, most recently from 9326d32 to 53b5dce Compare July 29, 2021 21:00
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
@restingbull restingbull force-pushed the restingbull/versioned-options branch from 53b5dce to 60c1e11 Compare July 29, 2021 22:28
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
Remove Dagger tests, as examples handles them

Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
@restingbull restingbull force-pushed the restingbull/versioned-options branch from 5e3eace to fb41786 Compare August 2, 2021 18:52
.bazelignore Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated

### Multi-repo runtime

The `rules_kotlin` runtime is comprised from multiple repositories. The end user will interact with a single repository, that repository delegates to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar nit: Either "is comprised of" or "comprises" (oddly).

@@ -0,0 +1,3 @@
# archive workspace

archive pr
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@restingbull restingbull merged commit da6e9ec into master Aug 6, 2021
@restingbull restingbull deleted the restingbull/versioned-options branch August 6, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants