Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --exclude_build_data arguement to singlejar invocation #566

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

skoeld
Copy link
Contributor

@skoeld skoeld commented Aug 4, 2021

Adding --exclude_build_data so that the build-data.properties won't be created.

This file contains contains information about the build host and will therefore break cacheing
for users that are not on the same platform as platform that built the cached artefact.

build-data.properties is not present in java artefacts since this flag is already applied so with this change, kotlin artefacts will have the same behaviour as java artifacts.

Adding --exclude_build_data so that the build-data.properties won't be created.

This file contains contains information about the build host and will therefore break cacheing
for users that are not on the same platform as the cached artifact.

build-data.properties is not created in pure java artifacts so with this change, kotlin artifacts will be inline with java.
@google-cla
Copy link

google-cla bot commented Aug 4, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@skoeld
Copy link
Contributor Author

skoeld commented Aug 4, 2021

@googlebot I signed it!

@restingbull restingbull merged commit c7966ef into bazelbuild:master Aug 6, 2021
@cgruber
Copy link
Collaborator

cgruber commented Aug 6, 2021

Thanks a lot!

@skoeld skoeld deleted the add_exclude_build_data_flag branch August 6, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants