WIP: Replace python-based JS extraction script with run_shell #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the python dependency in favor of a heavier reliance the shell. While not ideal right now, a resolution of bazelbuild/bazel#5511 would allow us to do the file grepping in starlark We could use entirely native rules this way, only calling out to the `jar` binary directly, which should be included with any jdk, and therefore result in a rule that is much leaner on dependencies while also more portable. Note: This hasn't been tested yet. I've thought a few times I did using the JS example, but each time it has turned out bazel ended up using different rules. This is a start, and an approach, but not a ready patch. This also still crucially lacks an implementation for .js.map files, which is technically trivial, but I'd like to ideally do it without invoking more shells.
TLATER
force-pushed
the
tlater/remove-python-nixless
branch
from
1bc4b6f
to
3d858c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial stab at #270 and removes the python dependency in favor of a heavier reliance the
shell.
While not ideal right now, a resolution of bazelbuild/bazel#5511 would allow us to do
the file grepping in starlark
We could use entirely native rules this way, only calling out to the
jarbinary directly, which should be included with any jdk, andtherefore result in a rule that is much leaner on dependencies while
also more portable.
Note: This hasn't been tested yet. I've thought a few times I did
using the JS example, but that still builds fine if I remove all relevant
code, so I don't think the modified rule actually ran ;) This is a start,
and an approach, but not a ready patch. I've run out of time for this
for now, so I'm pushing it for future reference.
This also still crucially lacks an implementation for .js.map files,
which is technically trivial, but I'd like to ideally do it without
invoking more shells.