Add support for env_inherit #942
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
reviewed
Apr 11, 2023
| @@ -303,7 +303,7 @@ def kt_jvm_junit_test_impl(ctx): | |||
| direct = ctx.files._java_runtime, | |||
| ), | |||
| # adds common test variables, including TEST_WORKSPACE. | |||
| testing.TestEnvironment(environment = ctx.attr.env), | |||
| testing.TestEnvironment(environment = ctx.attr.env, inherited_environment = ctx.attr.env_inherit), | |||
There was a problem hiding this comment.
inherited_environment wasn't added until Bazel 5.2.0 and will likely cause issues for anyone using Bazel 5.0.0 to 5.1.1.
There was a problem hiding this comment.
Actually thinking about this more - this should be safe to merge as people should be using the latest LTS release anyways or have a clear upgrade path by doing a minor 5.x version bump. What do you think @restingbull @nkoroste?
There was a problem hiding this comment.
I'm a little bit on: 7 was just pushed, supporting for is reaching.
Folks who need to keep Bazel at for are most likely not updating rules_kotlin
restingbull
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits (oldest to newest)
6302065 Add support for env_inherit