-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example package name does not follow Debian naming conventions. #143
Labels
Comments
It is not really inconsistent. version is just a string. If the user wants a conformant name, they can specify a version for the form version-revision, and you'll get a result that is fine. We should change the documentation to recommend |
aiuto
changed the title
Package Name is not compliant with Debian naming conventions.
example package name does not follow Debian naming conventions.
Jan 21, 2021
aiuto
added a commit
to aiuto/rules_pkg
that referenced
this issue
Jul 26, 2021
aiuto
added a commit
that referenced
this issue
Aug 2, 2021
* Change the Debian example to reflect standard Debian naming. Closes #143 * naming nits * format blocks * more formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This line appears to be incorrect
https://github.com/bazelbuild/rules_pkg/blob/master/pkg/pkg.bzl
line 375 out_deb = "%s_%s_%s.deb" % (package, version, architecture)
The the name is not following the correct syntax.
<foo>_<VersionNumber>-<DebianRevisionNumber>_<DebianArchitecture>.deb
(https://www.debian.org/doc/manuals/debian-faq/ch-pkg_basics.en.html)
foo_VVV-RRR_AAA.deb (where VVV, RRR and AAA are the version, revision and architecture of the package in question, respectively)
Package names (both source and binary, see Package) must consist only of lower case letters (a-z), digits (0-9), plus (+) and minus (-) signs, and periods (.). They must be at least two characters long and must start with an alphanumeric character.
Regular expressions are not currently supported. however some simple checks should be possible for example:
The text was updated successfully, but these errors were encountered: