Clarify intentions for this repo #2
Comments
|
Sure, I just didn't want to assume ownership and direction over the whole repo right from the get-go. :-) |
Merged
nacl
pushed a commit
to nacl/rules_pkg
that referenced
this issue
Feb 9, 2021
% This is the 1st commit message: Allow for more structured package mapping rule attributes This change modifies the `attributes` attribute of `pkg_files` and `pkg_mkdirs` to allow for more structured inputs than a list of strings. For the lack of a better option, the solution for this right now is to serialize the data in terms of JSON strings, which will be assembled using the new `pkg_attributes` macro. Users should always use `pkg_attributes` for this purpose. The JSON is decoded within the mapping rules and passed out through their providers. A better option would be to pass Providers full of structured data directly into rules, but, unfortunately Bazel does not support this at this time. % The commit message bazelbuild#2 will be skipped: % Whitespace cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Markus! Thanks for sending the initial PR for this repo. Small request—the README says "Currently these rules are focused on retrieving already built packages from repositories, not creating them as artifacts." ...
Can you expand a bit to clarify that we do, in fact, intend for this repo to expand and replace those built-in rules? (And an explanation about why that's a good thing to do?) Thanks!
The text was updated successfully, but these errors were encountered: