Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] adding strip_prefix, remap_paths, include_runfiles to pkg_zip #127

Closed

Conversation

grahamjenson
Copy link

I need to add include_runfiles attribute to pkg_zip and wanted to bring the pkg_tarandpkg_zip` rules closer to parity, so this PR adds the prepare_files method which both rules use to generate the list of added files.

Also updated the readme.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@grahamjenson
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@kigster
Copy link

kigster commented Jan 23, 2020

Any word when this may be reviewed and merged?

@cfeckardt
Copy link

+1 would like to see this merged soon too.

@aiuto
Copy link
Collaborator

aiuto commented Feb 28, 2020

I think we should be trying for a more general solution that lets us define packages of files, how they remap, and if runfiles are included in rules distinct from tar, deb and rpm. Then the packagers should get all the requisite remapping info in a provider from that rule. #128 is trying to go down that path. Let's see how that plays out first.

@aiuto
Copy link
Collaborator

aiuto commented Feb 28, 2020

/cc @nacl @beasleyr-vmw

@sreeramaraju
Copy link

pkgfilegroup from #127 is not public visible. Is there a workaround to pass strip_prefix for pk_zip rule till work related to that is merged to upstream?

@davschne
Copy link
Contributor

strip_prefix is now available for pkg_zip (see #221 above). I created the PR before I realized this one existed - whoops! I support this PR, though - it’s more complete and better leverages existing code. Could use some tests for remap_paths and include_runfiles.

@aiuto aiuto closed this Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants