-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] adding strip_prefix, remap_paths, include_runfiles to pkg_zip #127
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Any word when this may be reviewed and merged? |
+1 would like to see this merged soon too. |
I think we should be trying for a more general solution that lets us define packages of files, how they remap, and if runfiles are included in rules distinct from tar, deb and rpm. Then the packagers should get all the requisite remapping info in a provider from that rule. #128 is trying to go down that path. Let's see how that plays out first. |
/cc @nacl @beasleyr-vmw |
|
|
I need to add
include_runfiles
attribute topkg_zip and wanted to bring the
pkg_tarand
pkg_zip` rules closer to parity, so this PR adds the prepare_files method which both rules use to generate the list of added files.Also updated the readme.