Allow custom archive name for pkg_tar, pkg_deb, and pkg_zip targets #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiuto
requested changes
Jun 27, 2020
There was a problem hiding this comment.
This seems reasonable.
Have you looked at #193
In that we are discussing something a little more flexible, essentially being able to drop in things like cpu or architecture into the package name dynamically. I may finish up with that, but this would work as a start for that either way.
aiuto
approved these changes
Jul 1, 2020
|
This doesn't work because |
aiuto
added a commit
to aiuto/rules_pkg
that referenced
this pull request
Dec 8, 2020
|
You're right. I have a PR that fixes it, but I want to write some tests for the various cases. I won't get to that this week, most likely. In the meantime, you could try the patch. |
aiuto
added a commit
that referenced
this pull request
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #101