Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes for #221 into "main" #229

Closed
wants to merge 1 commit into from
Closed

Merge changes for #221 into "main" #229

wants to merge 1 commit into from

Conversation

nacl
Copy link
Collaborator

@nacl nacl commented Sep 4, 2020

Includes the fixes from #221 into the new "main" branch. It was previously committed to the "master" branch.

* Add attribute strip_prefix to pkg_zip

* Add tests for pkg_zip strip_prefix behavior
@nacl nacl requested a review from aiuto September 4, 2020 20:00
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@aiuto
Copy link
Collaborator

aiuto commented Sep 8, 2020

We may need @davschne to resend the PR to the main branch. Or just redo the change without attribution.

@davschne
Copy link
Contributor

davschne commented Sep 8, 2020

I'll redo my PR. Sorry about that; I assumed master was the default branch. For my future understanding, what's the role of master in this repository?

@aiuto
Copy link
Collaborator

aiuto commented Sep 9, 2020 via email

@davschne
Copy link
Contributor

davschne commented Sep 9, 2020

Thanks for the clarification, @aiuto.

Here's a new PR targeting main: #230

I rebased onto current HEAD of main, so it's a new commit with the same content.

@nacl
Copy link
Collaborator Author

nacl commented Sep 9, 2020

Obviated by #230. Thanks!

@nacl nacl closed this Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants