-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tar_writer.py
: address duplicate dir warning regression
#900
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@aiuto Some CI tests are failing. However, the failures do not appear to be related to this change. Do we know if |
Hold off for a second on this one - I've just tested it locally in my project to build tars for image layers to be used w/
I suspect that this is an issue specifically in the consumer/docker since duplicate directories should be valid - normal GNU EDIT: switched to just suppress the warning for dirs which was my original intention. The remaining test failures are actually unrelated now I think |
It looks like #850 removed the check below, resulting in warning being printed on duplicate directories in addition to files:
https://github.com/bazelbuild/rules_pkg/pull/850/files#diff-9a83a2a408d04cf1937eb6d1eac00438774072bfe46a19082c7f8729d3ac4a27L133-L135
Fixes #899