Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control mode on zip inputs (#96) #97

Merged
merged 4 commits into from
Jul 9, 2020
Merged

Control mode on zip inputs (#96) #97

merged 4 commits into from
Jul 9, 2020

Conversation

statik
Copy link
Contributor

@statik statik commented Sep 30, 2019

This seems to fix the issue. Tried adding a test, I'm happy to improve/polish based on your feedback.

@statik
Preserve unix attributes on zip inputs (bazelbuild#96)
4a8c3e7 
Signed-off-by: Elliot Murphy <statik@users.noreply.github.com>
@statik statik requested a review from aiuto as a code owner September 30, 2019 16:34
aiuto
aiuto reviewed Oct 1, 2019
View reviewed changes
pkg/build_zip.py Outdated Show resolved Hide resolved
@statik
Handle modes in pkg_zip similar to pkg_tar
c87df3e 
Signed-off-by: Elliot Murphy <statik@users.noreply.github.com>
@statik statik changed the title Preserve unix attributes on zip inputs (#96) Control mode on zip inputs (#96) Oct 7, 2019
@statik statik mentioned this pull request Oct 7, 2019
Closed
@statik statik mentioned this pull request Nov 26, 2019
Merged
@Gloix
Copy link

Gloix commented Jan 21, 2020 •
edited
Loading

Thank you for this, I actually stumbled upon this, so Bazel will not be the option for me, at least for now. Does the mode flag affect all source files? Say I want to pack an executable and a README file. Will they both have to be executable?

@statik statik requested a review from aiuto January 28, 2020 16:44
@mitchelldavis
Copy link

Can we get this pushed through?

@statik statik mentioned this pull request Jun 1, 2020
Closed
aiuto
aiuto approved these changes Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad on dropping this on the floor. I have no idea why I kept thinking I was waiting on you.

@statik
Copy link
Contributor Author

statik commented Jul 9, 2020

Thank you @aiuto! Life is busy, thank you for your work maintaining rules_pkg.

@aiuto
Update BUILD
2154b30 
Fix a merge
@aiuto aiuto merged commit 098022c into bazelbuild:master Jul 9, 2020
@aiuto
Copy link
Collaborator

aiuto commented Jul 9, 2020

To answer @Gloix 's question. This looks like it will do all files in the same way.
I think of this as a stop-gap. The more principled solution will use pkg_filegroup (when that gets finished) to finely specify modes and owners (in platform agnostic way) on a per-file basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiuto aiuto aiuto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@statik @Gloix @mitchelldavis @aiuto