Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py_wheel.publish doesn't take tags and requires passing args #1270

Closed
alexeagle opened this issue Jun 15, 2023 · 0 comments · Fixed by #1271
Closed

py_wheel.publish doesn't take tags and requires passing args #1270

alexeagle opened this issue Jun 15, 2023 · 0 comments · Fixed by #1271
Assignees
@alexeagle

Comments

@alexeagle
Copy link
Collaborator

It's difficult to use py_wheel's publish target for a couple reasons:

  • if you find deliverable targets using a bazel query for a certain tag, you don't find the publish executable because tags attribute isn't propagated
  • args like the repository url have to be passed when you bazel run the target, and can't be baked into the py_wheel definition
@alexeagle alexeagle self-assigned this Jun 15, 2023
alexeagle added a commit that referenced this issue Jun 15, 2023
@alexeagle
fix(py_wheel.publish): allow twine tags and args
b30637f 
Also fix missing runfiles on the py_wheel.dist target.

Fixes #1130
Fixes #1270
alexeagle added a commit that referenced this issue Jun 15, 2023
@alexeagle
fix(py_wheel.publish): allow twine tags and args
34bbb4e 
Also fix missing runfiles on the py_wheel.dist target.

Fixes #1130
Fixes #1270
@alexeagle alexeagle mentioned this issue Jun 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexeagle alexeagle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(py_wheel.publish): allow twine tags and args bazelbuild/rules_python
1 participant
@alexeagle