Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on incompatible_python_disallow_native_rules for end-to-end tests #1645

Open
alexeagle opened this issue Dec 21, 2023 · 2 comments
Open

Comments

@alexeagle
Copy link
Collaborator

alexeagle commented Dec 21, 2023

I'd like to enable that option in a repo downstream of rules_python, but it seems like there's a violation shipped with the project:

ERROR: /private/var/tmp/_bazel_alexeagle/3eecd93732ac7c6f4f360a54a468da50/external/rules_python~0.27.1~python~python_3_9_aarch64-apple-darwin/BUILD.bazel:63:11: in py_runtime rule @@rules_python~0.27.1~python~python_3_9_aarch64-apple-darwin//:py3_runtime: 
Traceback (most recent call last):
        File "/virtual_builtins_bzl/common/python/py_runtime_rule.bzl", line 24, column 25, in _py_runtime_impl
        File "/virtual_builtins_bzl/common/python/common.bzl", line 489, column 28, in check_native_allowed
Error in Label: invalid label in Label(): invalid package name '__EXTERNAL_REPOS__/rules_python~0.27.1~python~python_3_9_aarch64-apple-darwin/': package names may not end with '/' (perhaps you meant ":"?)
alexeagle added a commit that referenced this issue Dec 21, 2023
alexeagle added a commit that referenced this issue Dec 21, 2023
@rickeylev
Copy link
Contributor

This is, unfortunately, a bug in Bazel that I missed before release. It's fixed at head and planned for the 7.1 release in Feb.

This issue is the pkg portion of the label is empty. If the label was //something:py3_runtime, then it'd be OK. Hm, actually, maybe we could just create a sub-dir and stick an alias in there and things would be happy enough.

bazelbuild/bazel#17773 (comment)

Copy link

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

@github-actions github-actions bot added the Can Close? Will close in 30 days if there is no new activity label Jun 18, 2024
@rickeylev rickeylev removed the Can Close? Will close in 30 days if there is no new activity label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants