Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup proto rules and point to the source of truth #2173

Open
aignas opened this issue Sep 1, 2024 · 8 comments
Open

Cleanup proto rules and point to the source of truth #2173

aignas opened this issue Sep 1, 2024 · 8 comments
Milestone

Comments

@aignas
Copy link
Collaborator

aignas commented Sep 1, 2024

They have been moved to https://github.com/protocolbuffers/protobuf

Not sure who would be the best person to reach out about the status of wether the proto rules outside rules_python are useable already.

@aignas aignas added this to the v1.0.0 milestone Sep 1, 2024
@rickeylev
Copy link
Contributor

I think @alexeagle @comius were working on this? Last I remember, we were waiting for a protobuf release of something before we could switch rules_python to switch to loading them and mark them as deprecated.

@alexeagle
Copy link
Collaborator

I have not seen a migration plan for that. I don't think it's a wise plan to remove these from rules_python at this point. In fact much of the ecosystem has already moved off of the protobuf repo, now that the toolchain flag allows it.

@aignas
Copy link
Collaborator Author

aignas commented Sep 2, 2024

I think I must be confused as to what is the ruleset that should be used for protobuf python library - is it not the py_proto_library from the protobuff repo that should be used instead of the py_proto_library in our repo? What is the maintained rule that people should be advised to use? I thought that it was definitely not py_proto_library from rules_python but not sure about the replacement.

@alexeagle
Copy link
Collaborator

I find it confusing as well. The recent changes are anonymous and have no context or indication of what they are doing:

Screenshot 2024-09-02 at 3 44 50 PM

@aignas
Copy link
Collaborator Author

aignas commented Sep 3, 2024 via email

@aignas aignas changed the title Cleanup proto rules before releasing 1.0 Cleanup proto rules and point to the source of truth Sep 3, 2024
@aignas aignas modified the milestones: v1.0.0, Bzlmod GA, v2 Sep 3, 2024
@tpudlik
Copy link
Contributor

tpudlik commented Sep 6, 2024

This is the first I hear of a plan to deprecate py_proto_library in rules_python in favor of something in protobuf. Is there an issue or doc with more context?

@aignas
Copy link
Collaborator Author

aignas commented Sep 7, 2024

#1933 was the first time I heard of desire to do something like this.

@tpudlik
Copy link
Contributor

tpudlik commented Sep 9, 2024

@comius could you provide some clarity on what the plan is? If even the rules_python maintainers seem unsure, there's no hope for regular users like myself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants