-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup proto rules and point to the source of truth #2173
Comments
I think @alexeagle @comius were working on this? Last I remember, we were waiting for a protobuf release of something before we could switch rules_python to switch to loading them and mark them as deprecated. |
I have not seen a migration plan for that. I don't think it's a wise plan to remove these from rules_python at this point. In fact much of the ecosystem has already moved off of the protobuf repo, now that the toolchain flag allows it. |
I think I must be confused as to what is the ruleset that should be used for protobuf python library - is it not the py_proto_library from the protobuff repo that should be used instead of the py_proto_library in our repo? What is the maintained rule that people should be advised to use? I thought that it was definitely not py_proto_library from rules_python but not sure about the replacement. |
I guess then it means that we'll just continue having the api as is and we leave the removal for 2.0.
…On 3 September 2024 07:45:50 GMT+09:00, Alex Eagle ***@***.***> wrote:
I find it confusing as well. The recent changes are anonymous and have no context or indication of what they are doing:
<img width="1275" alt="Screenshot 2024-09-02 at 3 44 50 PM" src="https://github.com/user-attachments/assets/858b58a2-5703-4d19-ac05-14f8218ca4dc">
--
Reply to this email directly or view it on GitHub:
#2173 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
This is the first I hear of a plan to deprecate |
#1933 was the first time I heard of desire to do something like this. |
@comius could you provide some clarity on what the plan is? If even the |
They have been moved to https://github.com/protocolbuffers/protobuf
Not sure who would be the best person to reach out about the status of wether the proto rules outside rules_python are useable already.
The text was updated successfully, but these errors were encountered: