Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(py_wheel): Add support for specifying Description-Content-Type and Summary in METADATA #1274

Merged
merged 8 commits into from
Jun 16, 2023

Conversation

sfc-gh-zpeng
Copy link
Contributor

@sfc-gh-zpeng sfc-gh-zpeng commented Jun 15, 2023

py_wheel allows to supply a description file, but it does not allow specifying the content type of that file.
By default, the type is "text/x-rst", but many packages are using a markdown description.

https://packaging.python.org/en/latest/specifications/core-metadata/#description-content-type

This change added the support.

@sfc-gh-zpeng sfc-gh-zpeng requested a review from rickeylev as a code owner June 15, 2023 21:57
@sfc-gh-zpeng
Copy link
Contributor Author

@sfc-gh-sdas (fyi)

@sfc-gh-zpeng sfc-gh-zpeng changed the title Added support for specifying Description-Content-Type in METADATA feat(py_wheel): Added support for specifying Description-Content-Type in METADATA Jun 15, 2023
@sfc-gh-zpeng sfc-gh-zpeng changed the title feat(py_wheel): Added support for specifying Description-Content-Type in METADATA feat(py_wheel): Added support for specifying Description-Content-Type and Summary in METADATA Jun 16, 2023
@sfc-gh-zpeng
Copy link
Contributor Author

@sfc-gh-zpeng sfc-gh-zpeng requested a review from rickeylev June 16, 2023 16:46
@rickeylev rickeylev changed the title feat(py_wheel): Added support for specifying Description-Content-Type and Summary in METADATA feat(py_wheel): Add support for specifying Description-Content-Type and Summary in METADATA Jun 16, 2023
python/private/py_wheel.bzl Outdated Show resolved Hide resolved
@rickeylev rickeylev enabled auto-merge June 16, 2023 21:32
@rickeylev
Copy link
Collaborator

Docs look great, thank you!

@rickeylev rickeylev added this pull request to the merge queue Jun 16, 2023
Merged via the queue into bazelbuild:main with commit 643a14b Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants