-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(py_wheel): Add support for specifying Description-Content-Type and Summary in METADATA #1274
Merged
rickeylev
merged 8 commits into
bazelbuild:main
from
sfc-gh-zpeng:description-content-type
Jun 16, 2023
Merged
feat(py_wheel): Add support for specifying Description-Content-Type and Summary in METADATA #1274
rickeylev
merged 8 commits into
bazelbuild:main
from
sfc-gh-zpeng:description-content-type
Jun 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sfc-gh-sdas (fyi) |
sfc-gh-zpeng
changed the title
Added support for specifying Description-Content-Type in METADATA
feat(py_wheel): Added support for specifying Description-Content-Type in METADATA
Jun 15, 2023
rickeylev
requested changes
Jun 15, 2023
sfc-gh-zpeng
changed the title
feat(py_wheel): Added support for specifying Description-Content-Type in METADATA
feat(py_wheel): Added support for specifying Description-Content-Type and Summary in METADATA
Jun 16, 2023
I also added the "Summary" field: https://packaging.python.org/en/latest/specifications/core-metadata/#summary |
rickeylev
changed the title
feat(py_wheel): Added support for specifying Description-Content-Type and Summary in METADATA
feat(py_wheel): Add support for specifying Description-Content-Type and Summary in METADATA
Jun 16, 2023
rickeylev
approved these changes
Jun 16, 2023
Docs look great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
py_wheel
allows to supply a description file, but it does not allow specifying the content type of that file.By default, the type is "text/x-rst", but many packages are using a markdown description.
https://packaging.python.org/en/latest/specifications/core-metadata/#description-content-type
This change added the support.