Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: basic analysis tests for py_wheel #1279

Merged
merged 3 commits into from
Jun 20, 2023
Merged

test: basic analysis tests for py_wheel #1279

merged 3 commits into from
Jun 20, 2023

Conversation

rickeylev
Copy link
Collaborator

This adds some basic analysis tests of py_wheel to cover the functionality it's recently introduced.

@rickeylev rickeylev requested a review from chrislovecnm June 19, 2023 20:13
chrislovecnm
chrislovecnm approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buildifier found an unused variable. Otherwise LGTM

python/private/py_wheel.bzl Outdated Show resolved Hide resolved
@chrislovecnm chrislovecnm added this pull request to the merge queue Jun 20, 2023
Merged via the queue into bazelbuild:main with commit 89bec57 Jun 20, 2023
@rickeylev rickeylev deleted the pywheel.tests branch June 20, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickeylev @chrislovecnm