Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config_settings): allow matching minor version of python_version flag #1555

Merged
merged 9 commits into from
Jan 16, 2024
Prev Previous commit
Next Next commit
dont accept minor version as flag value, add missing import in tests
rickeylev committed Jan 16, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 8bcdd00ece7fcbcaddc1f00d194a0d5a1a770dd9
2 changes: 0 additions & 2 deletions python/config_settings/config_settings.bzl
Original file line number Diff line number Diff line change
@@ -35,8 +35,6 @@ def construct_config_settings(name, python_versions):
minor_to_micro_versions.setdefault(minor, []).append(micro_version)
allowed_flag_values.append(micro_version)

allowed_flag_values.extend(minor_to_micro_versions.keys())

string_flag(
name = "python_version",
# TODO: The default here should somehow match the MODULE config
Original file line number Diff line number Diff line change
@@ -16,6 +16,7 @@
load("@rules_testing//lib:analysis_test.bzl", "analysis_test")
load("@rules_testing//lib:test_suite.bzl", "test_suite")
load("@rules_testing//lib:truth.bzl", "subjects")
load("@rules_testing//lib:util.bzl", rt_util = "util")

_tests = []