test(bzlmod): refactor tests to not depend on implementation details #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
The change can be smaller, so I'll revert the path usage within the tests and will keep the helper methods returnitg strings. The implementation of those should return Path.name as opposed to just Path. |
rickeylev
approved these changes
Dec 18, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This refactors the `whl_mods` tests to not rely on the layout of the repositories, which I found to be needed whilst prototyping on bazelbuild#1625. Whilst doing this I realized that in general it would be great to support `Path` instances in the `runfiles` library, but that should be done next time.
aignas
force-pushed
the
test/refactor-example-tests
branch
from
79f316a to
0435762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the
whl_modstests to not rely on the layout of therepositories, which I found to be needed whilst prototyping on #1625.
Whilst doing this I realized that in general it would be great to
support
Pathinstances in therunfileslibrary, but that should bedone next time.