refactor(whl_library): reimplement wheel platform parsing in starlark #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parsing It seems that the CI did not catch this and I am wondering if we run our bzlmod example on a Mac. In the future I think that this code may need to move to starlark, because the same parsing from wheel name to platform identifiers is needed in bazelbuild#1685, but I'll do that in a separate PR. No changelog is needed because the feature this is fixing is unreleased yet.
aignas
changed the title
aignas
added a commit
to aignas/rules_python
that referenced
this pull request
Dec 20, 2023
rickeylev
reviewed
Dec 22, 2023
Co-authored-by: Richard Levasseur <richardlev@gmail.com>
rickeylev
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the CI did not catch the
macosx_10_9_universal2wheelsedge case, which this new code is handling. I moved the implementation
to starlark because #1625 needs this.
No changelog is needed because the feature this is fixing/refactoring
an unreleased feature.