fix(bzlmod): allow modules to register the same toolchain as rules_python's default #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aignas
approved these changes
Dec 20, 2023
…thon's default This fixes a bug where, if a module tries to register a non-default toolchain with the same version as rules_python's default toolchain, an error would occur. This happened because the earlier (non-default) toolchain caused the later (default) toolchain to be entirely skipped, and then no default toolchain would be seen. This most affects intermediary modules that need to register a toolchain, but can't specify a default one. To fix, just skip creating and registering the duplicate toolchain, but still check its default-ness to determine if it's the default toolchain. Fixes bazelbuild#1638
rickeylev
force-pushed
the
submodule.reregisters.default.toolchain
branch
from
5fbfeef to
5654c62
Compare
|
Hit this bug. Thank you so much for fixing. Is there a release that would include it on the horizon? |
|
Yes. The PR updating the changlog for 0.28.0 is in the merge queue now, a new release will be made once that's merged |
|
Amazing. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where, if a module tries to register a non-default toolchain with the
same version as rules_python's default toolchain, an error would occur. This happened
because the earlier (non-default) toolchain caused the later (default) toolchain to
be entirely skipped, and then no default toolchain would be seen. This most affects
intermediary modules that need to register a toolchain, but can't specify a default one.
To fix, just skip creating and registering the duplicate toolchain, but still check
its default-ness to determine if it's the default toolchain.
Fixes #1638