Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove MODULE.bazel.lock and ignore it #1680

Merged

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Jan 10, 2024

When we use the latest bazel release in the rules_python
module, then the lock file gets created, but I am not sure if
we should commit it in. Since the lock file is very useful
for local development as it speeds up dependency refetching,
this PR disables it as advised in the issue below. Whilst at
it, the bzlmod example also removes it for smaller diffs
when we develop extensions.

See bazelbuild/bazel#20369

@aignas aignas requested a review from rickeylev as a code owner January 10, 2024 23:54
Copy link
Collaborator

@rickeylev rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the change description to better explain why? Is it just to avoid the potential for the merge conflits? That's fine; I can get on board with that (such conflicts are really annoying), even though regenerating after a conflict should be pretty easy and cheap since our project is small.

@rickeylev rickeylev added this pull request to the merge queue Jan 13, 2024
Merged via the queue into bazelbuild:main with commit d9e42ac Jan 13, 2024
4 checks passed
@aignas aignas deleted the chore/remove-and-ignore-module-lock branch May 13, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants