Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update coveragepy to 7.4.3 #1798

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

oxidase
Copy link
Contributor

@oxidase oxidase commented Mar 12, 2024

The updated covergepy version contains a fix for nedbat/coveragepy#1733 which leads to sporadic issues

.../rules_python~~python~python_3_12_x86_64-unknown-linux-gnu_coverage/coverage/collector.py", line 511, in flush_data
    for fname, packeds in packed_data.items():
RuntimeError: dictionary changed size during iteration

@oxidase oxidase requested a review from rickeylev as a code owner March 12, 2024 18:41
@oxidase oxidase force-pushed the update_coveragepy branch from 29609ad to 84a362c Compare March 12, 2024 19:50
@aignas
Copy link
Collaborator

aignas commented Mar 13, 2024

Thanks for the contribution, could you please add a CHANGELOG.md entry (probably in the Changed section) to note that we are bumping the coverage.py version to address upstream bugs. Something like:

* Bump `coverage.py` to [7.4.3](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst#version-743--2024-02-23).

@oxidase oxidase force-pushed the update_coveragepy branch from 84a362c to 525ea5a Compare March 13, 2024 11:22
@oxidase
Copy link
Contributor Author

oxidase commented Mar 13, 2024

@aignas added

Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aignas aignas added this pull request to the merge queue Mar 15, 2024
Merged via the queue into bazelbuild:main with commit 565a531 Mar 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants