-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement missing METADATA parsing via pkginfo #198
Conversation
@brandjon Can you take a look? I think this patch is an important fix. |
Hi @brandjon. Please let us know if this project is maintained, or we should move to something else. There are multiple PRs and issues that are not answered for months. Importing pip packages doesn't work, using python3 is even in a worst state. |
Any updates on this pull request? Using Bazel in conjunction with python3/pip seems pretty painful without this. @brandjon |
I second @cgordoncarroll. Is there a way we could help to push this PR forward? |
Would be very interested in this being merged as well. Trying to use Bazel with Python3 deps. |
Have you tried any of these?
They all support Python 3. We are using the 1st with Python 3.6 at work. It was created after |
@thundergolfer Thanks I ended up using https://github.com/dillon-giacoppo/rules_python_external and it works perfectly. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
ab4bbe9
to
26b56c5
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
👋 1-year anniversary for this PR is coming up. Any chance we could get it merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only context for this code change is a close reading of the diff (unfortunately 😢 ), but with that in mind, this looks good to me.
Thanks a lot @andyscott! Would you like me to do anything else here? (The build of your merge failed because of an unrelated issue already fixed at head, afaict). |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
ba26361
to
ff884c1
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Hi! @thundergolfer @andyscott I removed the .par files from the PR, and squashed the commits. Is there anything else I should do here? Thank you! |
Hi |
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
Replaces the incomplete METADATA parsing with pkginfo. Adds tests using real-world packages.
Fixes #102