fix(whl_filegroup): Make RECORD from wheel available #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
TimotheusBachinger
force-pushed
the
deploy_record_with_whl_filegroup
branch
from
68d44e6
to
b05b8f9
Compare
TimotheusBachinger
changed the title
TimotheusBachinger
changed the title
TimotheusBachinger
requested review from
rickeylev and
aignas
as code owners
TimotheusBachinger
force-pushed
the
deploy_record_with_whl_filegroup
branch
from
b05b8f9
to
e5243cd
Compare
aignas
reviewed
Sep 26, 2024
CHANGELOG.md
Outdated
| @@ -66,7 +66,7 @@ A brief description of the categories of changes: | |||
| bootstrap .py file when using {obj}`--bootstrap_impl=script` | |||
| * (toolchain) The {bzl:obj}`gen_python_config_settings` has been fixed to include | |||
| the flag_values from the platform definitions. | |||
|
|
|||
| * (whl_filegroup): Provide per default also the `RECORD` file | |||
There was a problem hiding this comment.
Could you please rebase and update the CHANGELOG.md to point to things added in an unreleased version?
There was a problem hiding this comment.
hope it is now where you want it :-)
whl_filegroup will now per default also provide the RECORD file from the wheel
TimotheusBachinger
force-pushed
the
deploy_record_with_whl_filegroup
branch
from
e5243cd
to
a182a29
Compare
TimotheusBachinger
force-pushed
the
deploy_record_with_whl_filegroup
branch
from
a182a29
to
9a447c8
Compare
aignas
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is being made, briefly.
RECORDfile from a wheel in order to package everythingRECORDfile is not part ofwhl_filegroupeven no pattern filtering was applied (or I am misunderstanding something)hashnorfilelenhave been used in the code, so why are only files considered with those attributes?