Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolchains): default py_runtime.implementation_name to cpython #2272

Merged

Conversation

rickeylev
Copy link
Collaborator

This defaults py_runtime.implementation_name to cpython, the value that is most likely
to be used. This is done not only because it's the most likely value, but because of how
it affects whether precompiling works.

Within py_runtime, automatically computing pyc_tag requires both implementation_name
and Python version information. With upcoming changes to make --python_version always
set to the correct value, it'll make enabling precompiling easier, especially if there
are custom toolchains defined.

@rickeylev rickeylev requested a review from aignas as a code owner October 3, 2024 23:37
@aignas aignas added this pull request to the merge queue Oct 7, 2024
Merged via the queue into bazelbuild:main with commit 5c3b71c Oct 7, 2024
4 checks passed
@rickeylev rickeylev deleted the feat.pyruntime.default.cpython.impl branch October 18, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants