feat(toolchains): default py_runtime.implementation_name to cpython #2272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defaults
py_runtime.implementation_name
tocpython
, the value that is most likelyto be used. This is done not only because it's the most likely value, but because of how
it affects whether precompiling works.
Within py_runtime, automatically computing
pyc_tag
requires bothimplementation_name
and Python version information. With upcoming changes to make
--python_version
alwaysset to the correct value, it'll make enabling precompiling easier, especially if there
are custom toolchains defined.