Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use rules_shell #2305

Merged
merged 10 commits into from
Oct 16, 2024
Merged

chore: use rules_shell #2305

merged 10 commits into from
Oct 16, 2024
+86 −36

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Oct 15, 2024

Summary:

  • move bazelversion sh_test to //tests
  • add rules_shell dev dependency
  • use sh_test for the sh_py_run_test
  • use rules_shell in examples/bzlmod
  • use rules_shell in multi_python_versions example

Fixes #2299.

@aignas aignas requested a review from rickeylev as a code owner October 15, 2024 13:36
@aignas
Copy link
Collaborator Author

aignas commented Oct 15, 2024

Changing to draft until rules_shell is more ready.

@aignas aignas marked this pull request as draft October 15, 2024 14:11
@aignas aignas marked this pull request as ready for review October 16, 2024 15:28
@rickeylev rickeylev added this pull request to the merge queue Oct 16, 2024
Merged via the queue into bazelbuild:main with commit ced0c10 Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickeylev rickeylev rickeylev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bazel CI] Error no native function or rules 'sh_test'
2 participants
@aignas @rickeylev