refactor(pkg_aliases): create a macro for creating whl aliases #2391
+501
−443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bazel 9 integration tests are failing - I'll wait for the #2379. |
rickeylev
approved these changes
Nov 13, 2024
|
|
||
| def mock_select(value, no_match_error = None): | ||
| actual_no_match_error.append(no_match_error) | ||
| env.expect.that_str(no_match_error).equals("""\ |
There was a problem hiding this comment.
Oh ouch, this is brittle. I gotta add some StrSubject methods to make partial matching easier. FYI: .contains() can be used for less exact matching
Co-authored-by: Richard Levasseur <richardlev@gmail.com>
Co-authored-by: Richard Levasseur <richardlev@gmail.com>
Co-authored-by: Richard Levasseur <richardlev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just cleans up the code and moves more logic from the repository_rule
(i.e. generation of
BUILD.bazelfiles) to loading time (macro evaluation).This makes the unit testing easier and I plan to also move the code that is
generating config setting names from filenames to this new macro, but wanted to
submit this PR to reduce the review chunks.
Summary:
pkg_aliasesmacro.whl_aliasinpypiextension integration tests.whl_aliasfor passing to the pypi hub repo.Related to #260, #2386, #2337, #2319 - hopefully cleaning the code up will make
it easier to address those feature requests later.