Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pypi): Add extra_hub_aliases to pip_repository too #2426

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

gholms
Copy link
Contributor

@gholms gholms commented Nov 18, 2024

The extra_hub_aliases feature from #2369 has bindings in the pip extension
for bzlmod users, but not pip_repository for WORKSPACE users. But it
can work for either, so this patch moves it to the list of attrs the
two share and makes it work with the latter.

@gholms gholms requested review from aignas and groodt as code owners November 18, 2024 23:27
Copy link

google-cla bot commented Nov 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@aignas
Copy link
Collaborator

aignas commented Nov 18, 2024

LGTM, thanks for the contribution, things to make this mergeable:

  • Please update the lock file with pre-commit run update-bzlmod-lockfiles -a
  • Please add a note in CHANGELOG.md

@aignas aignas added this to the v1.0.0 milestone Nov 18, 2024
@gholms gholms requested a review from rickeylev as a code owner November 19, 2024 00:26
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@aignas aignas enabled auto-merge November 19, 2024 00:50
@aignas aignas added this pull request to the merge queue Nov 19, 2024
Merged via the queue into bazelbuild:main with commit d52b964 Nov 19, 2024
4 checks passed
@gholms gholms deleted the extra-hub-aliases branch November 19, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants