Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add feature to expose whether the native rules are used #2549

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

jsharpe
Copy link
Contributor

@jsharpe jsharpe commented Jan 7, 2025

Internally rules_python decides whether the implementation should use the legacy builtin rules from bazel or not.
The rules_python attributes have diverged from the builtin rules e.g. precompile and so a consumer of this library that wants to support bazel versions that are still using the legacy builtin rules needs a method to be able to query whether the rules are being used.

This change adds a entry to features.bzl to expose whether the legacy builtin rules are being used.

@rickeylev rickeylev added this pull request to the merge queue Jan 7, 2025
Merged via the queue into bazelbuild:main with commit edd6bb6 Jan 7, 2025
4 checks passed
@jsharpe jsharpe deleted the native_py_rules branch January 8, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants