Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update release check to ignore VERSION_NEXT substring in CONTRIBUTING.md #2553

Merged
merged 1 commit into from
Jan 9, 2025
Merged

chore: update release check to ignore VERSION_NEXT substring in CONTRIBUTING.md #2553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/create_archive_and_notes.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ set -o errexit -o nounset -o pipefail

# Exclude dot directories, specifically, this file so that we don't
# find the substring we're looking for in our own file.
if grep --exclude-dir=.* VERSION_NEXT_ -r; then
# Exclude CONTRIBUTING.md because it documents how to use these strings.
if grep --exclude=CONTRIBUTING.md --exclude-dir=.* VERSION_NEXT_ -r; then
echo
echo "Found VERSION_NEXT markers indicating version needs to be specified"
exit 1
Expand Down