Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to more recent pip version 21.0 -> 21.1 #529

Merged
merged 1 commit into from
Sep 12, 2021
Merged

Update to more recent pip version 21.0 -> 21.1 #529

merged 1 commit into from
Sep 12, 2021

Conversation

alexeagle
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Sep 8, 2021
@alexeagle alexeagle merged commit d2d08a7 into bazelbuild:main Sep 12, 2021
jheaff1 added a commit to jheaff1/rules_python that referenced this pull request Jan 5, 2022
@jheaff1
fix compile_pip_requirements on windows
b5d52d7 
PR bazelbuild#529 updated `click` to a version which depends on `colorama` on
Windows. This broke `compile_pip_requirements` on windows. This commit
resolves the issue by adding colorama as a dependency.
@jheaff1 jheaff1 mentioned this pull request Jan 5, 2022
Merged
12 tasks
alexeagle added a commit that referenced this pull request Jan 30, 2022
@jheaff1 @alexeagle
fix compile_pip_requirements on windows (#595)
f99ea2a 
PR #529 updated `click` to a version which depends on `colorama` on
Windows. This broke `compile_pip_requirements` on windows. This commit
resolves the issue by adding colorama as a dependency.

Co-authored-by: Alex Eagle <eagle@post.harvard.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thundergolfer thundergolfer thundergolfer approved these changes

@brandjon brandjon Awaiting requested review from brandjon

@lberki lberki Awaiting requested review from lberki

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @thundergolfer