Remove 'experimental' from pip_parse section #551
Conversation
Removes the "Experimental" tag from the `pip_parse` section of the README, and adds a note about the relatively new `compile_pip_requirements` rule.
| 1. `pip_parse` requires a fully resolved lock file of your python dependencies. You can generate this using | ||
| `pip-compile`, or a virtualenv and `pip freeze`. `pip_parse` uses a label argument called `requirements_lock` instead of `requirements` | ||
| to make this distinction clear. | ||
| 1. `pip_parse` requires a fully resolved lock file of your python dependencies. You can generate this by using the `compile_pip_requirements` rule, |
There was a problem hiding this comment.
Would you be willing to put an example of this together in the examples/ directory?
There was a problem hiding this comment.
Good idea. Probably won't have a chance for a few days.
There was a problem hiding this comment.
will try to merge this now, I don't think it's blocked by the example
|
I think this might have been done prematurely. Having started using |
Multiple people have been using
pip_parsefor months with no notable issues (from discussion in the #python Bazel Slack channel). This change removes the "Experimental" tag from thepip_parsesection of the README, and adds a note about the relatively newcompile_pip_requirementsrule.PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?