Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed stable stamping of wheels #567

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Nov 9, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently stable stamps do not make their way into wheels, this is the result of a copy/paste error in #554

Issue Number: N/A

What is the new behavior?

This change correctly wires up stable status stamp files for stamping py_wheel targets.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alexeagle alexeagle merged commit 0b11480 into bazelbuild:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants