Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added integration test for testing nuances of pip_repository macros #615

Merged
merged 3 commits into from
Feb 8, 2022

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Jan 29, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

#598 is too big to review so this PR breaks out a component of it.

Issue Number: N/A

What is the new behavior?

The tests in the pip_parse and pip_install examples are not cross platform since sphinx has differing dependency graphs between windows and linux/macos. This introduces a new integration test which continues to test important functionality on linux and macos until a cross platform solution is found.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@UebelAndre UebelAndre marked this pull request as ready for review January 29, 2022 21:33
@thundergolfer thundergolfer removed the request for review from andyscott February 1, 2022 10:53
@UebelAndre
Copy link
Contributor Author

UebelAndre commented Feb 4, 2022

@f0rmiga Thanks for the review! If this gets merged then I can open one more to finally fix Windows CI 😄

@f0rmiga f0rmiga merged commit 66b06b1 into bazelbuild:main Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants