-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude dist-info data from pip_repository targets #626
Conversation
cc @mattem who I think would be a good reviewer. |
@@ -147,6 +147,7 @@ def generate_build_file_contents( | |||
"**/* *", | |||
"**/*.py", | |||
"**/*.pyc", | |||
"*dist-info/**", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what else in dist-info
might be needed, or if anything is. However, we'll want **
as the prefix as some packages contain nested dist-info
dirs, internally we patch in "**/*dist-info/RECORD"
. I'll try and dig out the package we hit this one (that could take me a while, don't block)
"*dist-info/**", | |
"**/*dist-info/**", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've applied this patch but think it would be good to know the packages. I'm also not necessarily advocating for excluding all of dist-info
, I just don't know of a case where it's needed and I know it contains non-deterministic data. Happy to go with something more focused for now. I leave it up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll dig them out next week. I think this is likely fine to merge as is. Can always revert or update if it causes issues.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
This is a continuation of
__pycache__
contents and*.pyc
files in external dependencies #570 (comment)What is the new behavior?
The
dist-info
directory of a wheel is excluded from thepy_library
targets as they may contain volatile data.Does this PR introduce a breaking change?
Other information