Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip: 22.0.4 -> 22.1.2; pip-tools: 6.6.0 -> 6.6.2 #718

Merged
merged 13 commits into from
Jun 13, 2022

Conversation

groodt
Copy link
Collaborator

@groodt groodt commented Jun 2, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Upgrades pip and pip-tools to the latest versions.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@groodt groodt changed the title Bump pip tools pip: 22.0.4 -> 22.1.2; pip-tools: 5.5.0 -> 6.6.2 Jun 2, 2022
@groodt groodt marked this pull request as ready for review June 7, 2022 07:05
@groodt groodt changed the title pip: 22.0.4 -> 22.1.2; pip-tools: 5.5.0 -> 6.6.2 pip: 22.0.4 -> 22.1.2; pip-tools: 6.6.0 -> 6.6.2 Jun 7, 2022
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we ever figure out why the last time we bumped these, it affected users applications? We are in the same namespace that user pip installs go in?

@phlax
Copy link
Contributor

phlax commented Jun 12, 2022

Did we ever figure out why the last time we bumped these, it affected users applications?

pip-tools changed how it handles namespaced packages - - is used for . in package names - im guessing this is the issue you are referring to

@groodt
Copy link
Collaborator Author

groodt commented Jun 12, 2022

Did we ever figure out why the last time we bumped these, it affected users applications?

My issues were caused by the bump of pkginfo specifically #671 (which was bundled together with the upgrades of setuptools, pip and pip-tools) and was fixed when we removed that dependency here #700

@alexeagle
Copy link
Collaborator

Cool thanks for tracking that down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants