-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation to ensure requirements_lock is pinned. #732
Conversation
f4d0e45
to
b297542
Compare
Hi, looks like this breaks the ability to specify a hosted whl file in the requirements.in Having something like this in
generates this in
which basically then fails with
Seems like the check provided by pip, looks for Unless, I am missing something, it's breaking backward compatibility. |
* Light validation to ensure lockfile is pinned. * Clean up * . Co-authored-by: Alex Eagle <alex@aspect.dev>
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently nothing is checking if the
requirements_lock
is fully pinned. It's not technically possible to ensure that a lockfile is fully pinned (without actually attempting to resolve it), but a lightweight approximation is to ensure all individual requirements are pinned (i.e. have==
or===
).What is the new behavior?
Checks if the requirement is pinned, or throws an error.
Does this PR introduce a breaking change?
Other information