Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting python_runtime stub_shebang in python repository #804

Closed
wants to merge 4 commits into from

Conversation

fishcakez
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

A system installed python interpreter is required.

Issue Number: #691

What is the new behavior?

It is possible to avoid a system install python interpreter by setting hermetic_stub_shebang=True

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Extend the explanation (and added a warning) in ./README.md. A test is also added for every combination.

@google-cla
Copy link

google-cla bot commented Aug 26, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@fishcakez
Copy link
Contributor Author

For CI tests are failing because of unrelated issues fixed in #803 and #805.

@fishcakez
Copy link
Contributor Author

Added bug report about the CI issues in #806. Will come back to this PR when the above PRs are merged.

@groodt
Copy link
Collaborator

groodt commented Aug 27, 2022

Thanks for the PR. This isn't really a suitable solution to #691 however. Any solution would need to support Windows and it would also need to work when run outside the repository context (i.e. not using external/).

If you would like to proceed with this approach, you are able to do so already by overriding stub_shebang in the py_runtime.

@groodt groodt closed this Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants