update presubmit

.bazelci/presubmit.yml

@@ -539,6 +539,11 @@ tasks:
       - "//..."
       # The with_global_alloc directory is a repository on its own tested in the 'Build via cc_common.link using a global allocator' task.
       - "-//with_global_alloc/..."
+    coverage_targets:
+      - "--"
+      - "//..."
+      # The with_global_alloc directory is a repository on its own tested in the 'Build via cc_common.link using a global allocator' task.
+      - "-//with_global_alloc/..."
     build_flags:
       - "--@rules_rust//rust/settings:experimental_use_cc_common_link=True"
     test_flags:
@@ -551,6 +556,8 @@ tasks:
       - "//..."
     test_targets:
       - "//..."
+    coverage_targets:
+      - "//..."
     build_flags:
       - "--@rules_rust//rust/settings:experimental_use_cc_common_link=True"
       - "--@rules_rust//rust/settings:experimental_use_global_allocator=True"
@@ -565,6 +572,8 @@ tasks:
       - "//..."
     test_targets:
       - "//..."
+    # coverage_targets: # TODO: fix https://github.com/bazelbuild/rules_rust/issues/2838
+    #   - "//..."
     build_flags:
       - "--@rules_rust//rust/toolchain/channel=nightly"
       - "--@rules_rust//rust/settings:experimental_use_cc_common_link=True"

rust/private/rustc.bzl

@@ -1434,9 +1434,8 @@ def rustc_compile_action(
 
         coverage_link_flags = []
         if include_coverage:
-            # coverage fails due to gcc lacking a few linker args
-            # this fixes missing symbols and links against the c lib
-            coverage_link_flags = ["-u", "__llvm_profile_runtime", "-lc"]
+            # fixes missing symbols coverage fails due to gcc lacking a few linker args
+            coverage_link_flags = ["-u", "__llvm_profile_runtime"]
 
         cc_common.link(
             actions = ctx.actions,