-
Notifications
You must be signed in to change notification settings - Fork 428
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix cargo-bazel recompile for MODULE.bazel (#2570)
- Addresses #2531 - Wrote a function, thats basically copy / pasted from `crates_universe/private/generate_utils.bzl` to account for the `module_ctx` Can probably make the original function more generic if thats more desired. I'm not sure if the maintainers would prefer a one off, since the `MODULE.bazel `feature set for `crates_universe` isn't exactly "Stable" yet. - Noticed theres no way to "bootstrap" the new `cargo` features in `MODULE.bazel` , like you can for `crates_universe`. May need to open an issue for this. Tested by using the `CARGO_BAZEL_GENERATOR_URL` and `CARGO_BAZEL_GENERATOR_SHA256` environmentals. This looks to cause some failing unit tests. Not sure how to get support on this - Failsafe of using the cargo buildstrap `cargo-bazel` if no URLs are found, and if theres no environmentals. --------- Co-authored-by: UebelAndre <github@uebelandre.com>
- Loading branch information
1 parent
98fab85
commit fc601ba
Showing
2 changed files
with
56 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters