Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for rules_proto 6.x #2668

Open
aira-xite opened this issue May 28, 2024 · 0 comments
Open

Support for rules_proto 6.x #2668

aira-xite opened this issue May 28, 2024 · 0 comments

Comments

@aira-xite
Copy link

In the latest version of rules_proto several breaking changes have been made, in particular rules_proto_toolchains has been moved and it breaks build of rules_rust.

ERROR: Traceback (most recent call last):
        File "..../external/rules_rust/proto/protobuf/transitive_repositories.bzl", line 4, column 75, in <toplevel>
                load("@rules_proto//proto:repositories.bzl", "rules_proto_dependencies", "rules_proto_toolchains")
Error: file '@rules_proto//proto:repositories.bzl' does not contain symbol 'rules_proto_toolchains'

Please consider adding support for it.
@marvin-hansen marvin-hansen mentioned this issue Jun 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 12, 2024
@marvin-hansen @illicitonion
Bazelmod documentation and code examples. (#2713)
c177ccc 
This PR provides documentation of Bazelmod and several code examples
that addresses a number of issues related to Bazelmod.

Preview of the documentation:
https://github.com/marvin-hansen/rules_rust/blob/main/docs/crate_universe_bzlmod.md

First and foremost it paves the way for a meaningful update the Bazelmod
documentation that references these and existing code examples. This
touches at least the following issues:
* #2670
* #2181


The compile_opt example addresses or resolves:
*  #515
* #2701

The musl_cross_compilling example addresses or resolves
* #390 
* #276

The oci_container does not relate to any open issue, 
although the tokio example in it gives a nice end to end example so 
this definitely helps those looking for something non-trivial.

The proto example addresses or resolves:
*  #2668
*  #302
* #2534
* Possibly a few more if I were to search longer

Formalities
* I've signed the CLA
* I've signed all commits

---------

Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aira-xite