Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor tinyjson sources to make process_wrapper deterministic #1729

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jfirebaugh
Copy link
Contributor

Fixes #1530

@scentini
Copy link
Collaborator

I was also working on fixing this today over at #1728. I believe it's the more desireable approach as it will allow us to to add further dependencies of the process wrapper (should we need them) without vendoring them.

@jfirebaugh
Copy link
Contributor Author

I saw that! Either approach seems viable to me. I'm happy with whatever the maintainers decide.

@UebelAndre
Copy link
Collaborator

UebelAndre commented Dec 23, 2022

I too would lean away from vendoring code if possible 😄

@jfirebaugh
Copy link
Contributor Author

The approach in #1728 would prevent fixing #1601.

@jfirebaugh
Copy link
Contributor Author

In main...jfirebaugh:rules_rust:jfirebaugh/integration_tests, I wrote an integration test for the issue using rules_bazel_integration_test. It fails prior to this fix and passes afterward.

Let me know what you think of that approach. It could be useful no matter which of the two PRs gets merged, and a good basis for writing integration tests in general.

@UebelAndre
Copy link
Collaborator

The approach in #1728 would prevent fixing #1601.

I'm generally not a fan of vendoring code to projects like this but tinyjson is indeed tiny. I'm curious how exactly this solves determinism issues though. Is it deterministic based on where you checkout the repo or otherwise?

Additionally, does it make a difference if tinyjson is it's own target vs a part of the process_wrapper itself? I would prefer it if tinyjson could remain it's own package. Finally, could a tool (small script) be added to re-vendor the project? I would like make bringing in new changes as painless as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MacOS host paths being written into binaries
3 participants