Disable Bzlmod explicitly in .bazelrc #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
reviewed
Oct 6, 2023
There was a problem hiding this comment.
Thanks!
We also have a bunch of workspaces we use for testing - should we do the same in each of those?
% find . -name .bazelrc
./examples/crate_universe/cargo_workspace/.bazelrc
./examples/crate_universe/cargo_aliases/.bazelrc
./examples/crate_universe/cargo_remote/.bazelrc
./examples/crate_universe/no_cargo_manifests/.bazelrc
./examples/crate_universe/.bazelrc
./examples/crate_universe/multi_package/.bazelrc
./examples/bzlmod/hello_world/.bazelrc
./examples/crate_universe_unnamed/.bazelrc
./examples/zig_cross_compiling/.bazelrc
./examples/ios/.bazelrc
./examples/android/.bazelrc
./examples/ios_build/.bazelrc
./examples/.bazelrc
./.bazelrc
|
Until you also fully migrate those examples to Bzlmod, probably we should, but not for |
|
Done, please take another look! |
meteorcloudy
force-pushed
the
meteorcloudy-patch-1
branch
3 times, most recently
from
30f2f35
to
6e5f12a
Compare
meteorcloudy
force-pushed
the
meteorcloudy-patch-1
branch
from
6e5f12a
to
3f446c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help make sure Bazel Downstream Pipeline is green after enabling Bzlmod at Bazel@HEAD
See bazelbuild/bazel#18958 (comment)
Related issue: #2181