[prost] includes prost crate infos in rust_analyzer_aspect #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change is fairly straightforward, but I did need to move prost providers up to `prost/providers.bzl` and out of `private/prost.bzl` to avoid a cyclic dependency. What we do is: * change `rust_prost_library` to return the `rust_proto_info` provider * in the `rust-analyzer` aspect we iterate over transitive dep infos and generate the appropriate `RustAnalyzerInfo` * lastly, we use the `crate_info` from `ProstProtoInfo` if we're processing a prost target as the "root" `crate_info` There are a couple of things I'm not sure are correct: 1. For every prost dep I set `deps` to `[]` - I think that's correct but I'm not sure-sure. 2. Similarly I set `proc_macro_dylib_path` to always `None` - again I think that's correct, but not sure-sure. Fixes bazelbuild#2121.
UebelAndre
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is fairly straightforward, but I did need to move prost
providers up to
prost/providers.bzland out ofprivate/prost.bzltoavoid a cyclic dependency.
What we do is:
rust_prost_libraryto return therust_proto_infoproviderrust-analyzeraspect we iterate over transitive dep infos andgenerate the appropriate
RustAnalyzerInfocrate_infofromProstProtoInfoif we'reprocessing a prost target as the "root"
crate_infoThere are a couple of things I'm not sure are correct:
depsto[]- I think that's correct butI'm not sure-sure.
proc_macro_dylib_pathto alwaysNone- again Ithink that's correct, but not sure-sure.
Fixes #2121.