Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to mirror github releases to bazel central registry #2256

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

kageiit
Copy link
Contributor

@kageiit kageiit commented Nov 11, 2023

Add machinery to automatically push GitHub releases to bazel central registry. This will need some setup by the ruleset maintainers to enable the GitHub app when bzlmod support is ready. See the instructions for more details

Ref #2181

Copy link

google-cla bot commented Nov 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@@ -0,0 +1,3 @@
fixedReleaser:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workaround for this issue

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you know what would be required in also uploading cargo-bazel binaries?

@kageiit
Copy link
Contributor Author

kageiit commented Nov 14, 2023

Thanks! Do you know what would be required in also uploading cargo-bazel binaries?

Im not sure. I tried to look in the docs/bcr source but was not able to find anything regarding uploading binaries separately so far

@UebelAndre UebelAndre merged commit 6d35ac1 into bazelbuild:main Nov 14, 2023
3 checks passed
@kageiit kageiit deleted the mirror_to_bcr branch November 14, 2023 17:05
@UebelAndre
Copy link
Collaborator

@kageiit we've since done release 0.31.0 but I don't think I see any change in https://github.com/bazelbuild/bazel-central-registry. Did this PR have the intended effect?

@kageiit
Copy link
Contributor Author

kageiit commented Nov 27, 2023

instructions

I believe the repo maintainers have to give access to the github app to listen to the relevant webhooks. I added a link to it in the PR description - https://github.com/apps/publish-to-bcr . @UebelAndre you will have to install the app for the changes to take effect

@UebelAndre
Copy link
Collaborator

I unfortunately don't know anything about Github apps. Maybe @scentini can take a look since they're an admin of the repo?

@cgrindel
Copy link
Contributor

@UebelAndre Under the How it works section for publish-to-bcr, it mentions that repositories under bazelbuild will need a personal fork of bazel-central-repository. Since you are listed as the fixedReleaser, you will need to create the fork under your account and configure the publish-to-bcr app in the fork.

After that, we will need someone at Google to enable the publish-to-bcr app for this repository.

@scentini
Copy link
Collaborator

scentini commented Dec 1, 2023

I already enabled the publish-to-bcr app for rules_rust.

@cgrindel
Copy link
Contributor

cgrindel commented Dec 1, 2023

@scentini Thanks!

@UebelAndre I believe that the fork is the last piece of the puzzle. Once that is ready, we should be able to create a release and see a PR in the BCR. 🤞

@UebelAndre
Copy link
Collaborator

@scentini I think it'd be best if you (or some Googler) made the fork. Would you mind making one?

@scentini
Copy link
Collaborator

scentini commented Dec 4, 2023

Here's a fork with publish-to-bcr configured, and here's a PR to make me the fixedReleaser

@cgrindel
Copy link
Contributor

cgrindel commented Dec 6, 2023

@scentini Thank you for setting up the fork and making yourself the fixedReleaser. Are we ready to create a release and see it publish to BCR?

@dtolnay
Copy link
Contributor

dtolnay commented Dec 13, 2023

Rules_rust 0.33.0 was recently released and I don't see anything having happened in bazel-central-registry.

Does something need to be done on their end regarding bazelbuild/bazel-central-registry#329?

@cgrindel
Copy link
Contributor

I thought that we had all of our ducks lined up. I will investigate.

@dtolnay
Copy link
Contributor

dtolnay commented Dec 16, 2023

It worked for 0.34.1. bazelbuild/bazel-central-registry#1199

@cgrindel
Copy link
Contributor

Sweet. Unfortunately, the presubmit is failing. I should be able to investigate on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants