Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crate_universe: Don't preform path translation on out_dir #2844

Merged
merged 1 commit into from
Sep 13, 2024
Merged

crate_universe: Don't preform path translation on out_dir #2844

merged 1 commit into from
Sep 13, 2024

Conversation

konkers
Copy link
Contributor

@konkers konkers commented Sep 6, 2024

Bug: #2801

@konkers konkers mentioned this pull request Sep 6, 2024
Closed
@krasimirgg
Copy link
Collaborator

Thank you! Could you also set up a new presubmit running some of the blzmod examples with --incompatible_use_plus_in_repo_names.

@krasimirgg krasimirgg self-requested a review September 10, 2024 08:39
@konkers konkers force-pushed the pr/path_translation branch 3 times, most recently from b1af85b to 498ce62 Compare September 11, 2024 21:11
@konkers
Copy link
Contributor Author

konkers commented Sep 11, 2024

Apologies for the noise. Trying to get CI working.

@konkers konkers force-pushed the pr/path_translation branch 2 times, most recently from cb9b1e8 to 6839898 Compare September 11, 2024 21:33
@konkers
Copy link
Contributor Author

konkers commented Sep 11, 2024

OK churn done. I have added tests using --incompatible_use_plus_in_repo_names. This was a bit complicated by the fact that

  1. The command line flag does not exist in the bazel version use by the test by default
  2. The repo names leak into the lock file causing --lockfile_mode=error to fail

krasimirgg
krasimirgg approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@krasimirgg krasimirgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@krasimirgg krasimirgg added this pull request to the merge queue Sep 13, 2024
Merged via the queue into bazelbuild:main with commit 30df2ef Sep 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krasimirgg krasimirgg krasimirgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konkers @krasimirgg