Update crate_universe to determine dep+feature trees per host #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
force-pushed
the
crate_universe
branch
from
3004568
to
ee36fda
Compare
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
illicitonion
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change expands the use of
cargo treeto resolve features for different combinations ofhost -> targetplatform triples where beforecargo-bazelwas only capable of resolving host dependencies for the current host platform and not a foreign platform.A lengthy description of how this was done can be found at
crate_universe/src/metadata/cargo_tree_resolver.rs - TreeResolver::create_rustc_wrapper.closes #2212