Use up to date stardoc to avoid build errors #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregBowyer
requested review from
acmcarther,
damienmg and
mfarrugi
as code owners
GregBowyer
force-pushed
the
stardoc-update
branch
from
dd70f22
to
49503de
Compare
GregBowyer
force-pushed
the
stardoc-update
branch
3 times, most recently
from
f229316
to
ad991db
Compare
|
So this should be fixed, but not sure why the buildkite is stalled out, ideas? |
|
Looks like it ran and hit a new (flaky?) error.
…On Fri, Jan 10, 2020, 19:19 Greg Bowyer ***@***.***> wrote:
So this should be fixed, but not sure why the buildkite is stalled out,
ideas?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#290?email_source=notifications&email_token=AAROG6DLWQUJT3GN6B7PIE3Q5EGCZA5CNFSM4KFLCQ7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIVS62Q#issuecomment-573255530>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAROG6G5IIKNHTBMPH3F5E3Q5EGCZANCNFSM4KFLCQ7A>
.
|
SkyDoc has become Stardoc some time ago, and has a few mistakes in its older versions regarding workspace paths and contexts. This didnt matter until bazel 2.0 where these are treated more strictly. As such we bump to the latest stardoc which allows for building out rules_rust on bazel 2.0+
GregBowyer
force-pushed
the
stardoc-update
branch
from
90d3108
to
4d35fc7
Compare
|
Ok more fiddling, now we should be fixed. Do we want this merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SkyDoc has become Stardoc some time ago, and has a few mistakes in its
older versions regarding workspace paths and contexts. This didnt matter
until bazel 2.0 where these are treated more strictly.
As such we bump to the latest stardoc which allows for building out
rules_rust on bazel 2.0+